Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing param validation issue145 #193

Merged
merged 9 commits into from
Jul 24, 2020
Merged

Conversation

medelibero-sfdc
Copy link
Contributor

Proposed fix for #145

Copy link
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few suggestions for the wording and shortening the function slightly.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lib/cookie.js Outdated Show resolved Hide resolved
@awaterma
Copy link
Member

I'm also wondering if we should look at other methods that could benefit from this parsing.

@ShivanKaul
Copy link
Contributor

@awaterma did you have any other comments on this PR? It looks good to merge to me.

Copy link
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good; we can revisit pulling this in as a dependency if we end up adding more or require different validations in the future. Thank you @medelibero-sfdc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants